-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node 12 compatibility #5
Conversation
Thanks please also forward patch upstream and crosslink URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM may others @abandonware/maintainers confirm
please also open issue on upstream tracker too
Do you mean backporting this patch onto upstream master, or just opening an issue attempting to notify upstream about these changes? |
Opening the issue is a good start and should be enough, then It will be appreciated that you also comment the pending PRs, and eventually pick and port them to @abandonware fork if relevent, then I will release a new version, does this sound like a good plan? |
Alright, I opened noble#114 in the upstream repo. Re the other PRs in upstream, I can maybe take a look, sure. :) |
Can I help you with this somehow? Want to use latest node version, but this issue is preventing it. |
@rzr Can you do a new release? |
I can try as soon I get a better connectivity |
https://www.npmjs.com/package/@abandonware/bluetooth-hci-socket/v/0.5.3-3 release Btw please angine fix appvendor then i will use Travis to publish on pushed tag |
This PR adds compatibility for the Node 12.x series, as required for my downstream project Ruuvidriver: akx/ruuvidriver#3