Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 12 compatibility #5

Merged
merged 6 commits into from
Sep 16, 2019
Merged

Node 12 compatibility #5

merged 6 commits into from
Sep 16, 2019

Conversation

akx
Copy link

@akx akx commented Aug 28, 2019

This PR adds compatibility for the Node 12.x series, as required for my downstream project Ruuvidriver: akx/ruuvidriver#3

@rzr
Copy link

rzr commented Aug 28, 2019

Thanks please also forward patch upstream and crosslink URL

Copy link

@rzr rzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM may others @abandonware/maintainers confirm

please also open issue on upstream tracker too

Cc: @mrstegeman @gfwilliams

@akx
Copy link
Author

akx commented Aug 28, 2019

Thanks please also forward patch upstream and crosslink URL

Do you mean backporting this patch onto upstream master, or just opening an issue attempting to notify upstream about these changes?

@rzr
Copy link

rzr commented Aug 28, 2019

Opening the issue is a good start and should be enough, then It will be appreciated that you also comment the pending PRs, and eventually pick and port them to @abandonware fork if relevent, then I will release a new version, does this sound like a good plan?

@akx
Copy link
Author

akx commented Aug 28, 2019

Alright, I opened noble#114 in the upstream repo. Re the other PRs in upstream, I can maybe take a look, sure. :)

@janhaa
Copy link

janhaa commented Sep 16, 2019

Can I help you with this somehow? Want to use latest node version, but this issue is preventing it.

@mrstegeman mrstegeman merged commit 250a66e into abandonware:master Sep 16, 2019
@mrstegeman
Copy link

@rzr Can you do a new release?

@rzr
Copy link

rzr commented Sep 17, 2019

I can try as soon I get a better connectivity

@rzr
Copy link

rzr commented Sep 17, 2019

https://www.npmjs.com/package/@abandonware/bluetooth-hci-socket/v/0.5.3-3 release

Btw please angine fix appvendor then i will use Travis to publish on pushed tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants